]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
extensions-app: Use new add_action_entries() override
authorFlorian Müllner <fmuellner@gnome.org>
Wed, 6 Jul 2022 12:16:38 +0000 (14:16 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 1 Aug 2022 11:03:32 +0000 (13:03 +0200)
g_action_map_add_entries() is a C convenience API that isn't
introspectable, but gjs recently added a JS override for it.

Use it to save some boilerplate.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2371>

subprojects/extensions-app/js/main.js

index 98922363d1dbd0580f4c003d9c59f3d75bf96df9..2d8ff1111a9d6043504d4295586f293832a0ae42 100644 (file)
@@ -58,9 +58,11 @@ class Application extends Adw.Application {
     vfunc_startup() {
         super.vfunc_startup();
 
-        const action = new Gio.SimpleAction({ name: 'quit' });
-        action.connect('activate', () => this._window.close());
-        this.add_action(action);
+        this.add_action_entries(
+            [{
+                name: 'quit',
+                activate: () => this._window.close(),
+            }]);
 
         this.set_accels_for_action('app.quit', ['<Primary>q']);
 
@@ -95,24 +97,20 @@ var ExtensionsWindow = GObject.registerClass({
         this._exporter = new Shew.WindowExporter({ window: this });
         this._exportedHandle = '';
 
-        let action;
-        action = new Gio.SimpleAction({ name: 'show-about' });
-        action.connect('activate', this._showAbout.bind(this));
-        this.add_action(action);
-
-        action = new Gio.SimpleAction({ name: 'logout' });
-        action.connect('activate', this._logout.bind(this));
-        this.add_action(action);
-
-        action = new Gio.SimpleAction({
-            name: 'user-extensions-enabled',
-            state: new GLib.Variant('b', false),
-        });
-        action.connect('activate', toggleState);
-        action.connect('change-state', (a, state) => {
-            this._shellProxy.UserExtensionsEnabled = state.get_boolean();
-        });
-        this.add_action(action);
+        this.add_action_entries(
+            [{
+                name: 'show-about',
+                activate: () => this._showAbout(),
+            }, {
+                name: 'logout',
+                activate: () => this._logout(),
+            }, {
+                name: 'user-extensions-enabled',
+                state: 'false',
+                change_state: (a, state) => {
+                    this._shellProxy.UserExtensionsEnabled = state.get_boolean();
+                },
+            }]);
 
         this._searchTerms = [];
         this._searchEntry.connect('search-changed', () => {